[Rpm-maint] [rpm-software-management/rpm] Fix regression causing patch/source tags leaking to other macros (#709)
Panu Matilainen
notifications at github.com
Mon May 20 10:04:05 UTC 2019
Commit 6dafb24684baa71fe3b89be6404e6ab0362cf316 introduced a regression
where patch/source (and likely buildroot and docdir too) values
end up leaking to macros of other tags, due to missing reinitialization
to NULL in the code.
This only shows up in specs ordered in a specific way which is why
our test-suite failed to trip it, but it caused eg Fedora attr.spec and
kernel.spec to fail parse. Hijack the otherwise unused foo.spec to
create a test-case for this.
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/709
-- Commit Summary --
* Fix regression causing patch/source tags leaking to other macros
-- File Changes --
M build/parsePreamble.c (3)
M tests/data/SPECS/foo.spec (20)
M tests/rpmspec.at (31)
-- Patch Links --
https://github.com/rpm-software-management/rpm/pull/709.patch
https://github.com/rpm-software-management/rpm/pull/709.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/709
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190520/7ebacf2d/attachment.html>
More information about the Rpm-maint
mailing list