[Rpm-maint] [rpm-software-management/rpm] Implement %elif (#710)

[Panu Matilainen]

pmatilai commented on this pull request.



> @@ -501,17 +506,24 @@ int readLine(rpmSpec spec, int strip)
 	goto retry;
     }
 
-after_classification:
-    if (match != -1) {
+    if (lineType->id & (LINE_IF | LINE_IFARCH | LINE_IFNARCH | LINE_IFOS |
+	    LINE_IFNOS)) {

This calls for a bitmask, something like LINE_IFANY, which can be used to trap all the types with one symbol. Makes the line shorter and more readable. (fwiw no I'm not reviewing, just taking a look)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/710#pullrequestreview-239978224
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190521/09422de3/attachment.html>