[Rpm-maint] [rpm-software-management/rpm] Implement %elif (#710)

[Panu Matilainen]

pmatilai commented on this pull request.



>  	rl->lastConditional = lineType;
 	spec->readStack = rl;
 	spec->line[0] = '\0';
+    } else if (lineType->id & (LINE_ELIF | LINE_ELIFARCH | LINE_ELIFOS)) {

The various ELIF's are another candidate for a bit mask, this set is repeated at least twice in the patch (used earlier in the "dont expand in false branch" check). In general, when addressing something, it pays to look for similar cases/opportunities/bugs, they're quite often there.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/710#pullrequestreview-240605405
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190522/0b6a92ff/attachment.html>