[Rpm-maint] [rpm-software-management/rpm] Dynamic Build Dependencies (#593)

[Panu Matilainen]

pmatilai commented on this pull request.



> @@ -228,12 +229,13 @@ static rpmRC doCheckBuildRequires(rpmts ts, rpmSpec spec, int test)
     rpmps ps = rpmSpecCheckDeps(ts, spec);
 
     if (ps) {
-	rpmlog(RPMLOG_ERR, _("Failed build dependencies:\n"));
-	rpmpsPrint(NULL, ps);
-    }
-    if (ps != NULL)
+	if (rpmIsVerbose()) {
+	    rpmlog(RPMLOG_ERR, _("Failed build dependencies:\n"));

This newly added condition is wrong, errors and warnings must be emitted in --quiet mode too. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/593#pullrequestreview-241629418
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190524/36fb1167/attachment-0001.html>