[Rpm-maint] [rpm-software-management/rpm] Always use unified diff format in check-files (#928)
Panu Matilainen
notifications at github.com
Thu Nov 7 08:33:06 UTC 2019
pmatilai requested changes on this pull request.
You can see what is changed by simply looking at the diff, but the all important *what does it do* and *why* is this change needed are completely missing in the commit message.
There's also a portability concern here: the reason for using non-unidiff in the first place is because -u is not standard, and it has only recently gotten included in the Open Group diff specification (2018 edition - far too new to rely on).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/928#pullrequestreview-313174975
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20191107/96aba55a/attachment.html>
More information about the Rpm-maint
mailing list