[Rpm-maint] [rpm-software-management/rpm] Stop blocking when GPG process dies prematurely (RhBug:1746353) (#938)

[Panu Matilainen]

pmatilai commented on this pull request.



> @@ -238,11 +239,25 @@ static rpmtd makeSigTag(Header sigh, int ishdr, uint8_t *pkt, size_t pktlen)
     return sigtd;
 }
 
+pid_t gpgPid = 0;

I don't trust myself to do a proper review this late on Friday afternoon (and neither should you) :smile:  but just a quick comment: this variable needs to be declared static, otherwise it'll end up visible in the library ABI.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/938#pullrequestreview-321583545
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20191122/c31ba34c/attachment-0001.html>