[Rpm-maint] [rpm-software-management/rpm] Fix compatible-release, versions with dot-star, semantically versioned deps, and python version (#951)
Neal Gompa (ニール・ゴンパ)
notifications at github.com
Mon Nov 25 03:00:11 UTC 2019
Conan-Kudo requested changes on this pull request.
> @@ -16,6 +16,7 @@
from sys import argv, stdin, version
from distutils.sysconfig import get_python_lib
from warnings import warn
+from pkg_resources import parse_version
Please do not do this import at the top of the file. It massively slows down the execution of the script. Instead, add the `parse_version` import to the existing `from pkg_resources` line further down in the script.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/951#pullrequestreview-322020614
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20191124/d70baa2e/attachment.html>
More information about the Rpm-maint
mailing list