[Rpm-maint] [rpm-software-management/rpm] Stop blocking when GPG process dies prematurely (RhBug:1746353) (#938)

[Panu Matilainen]

pmatilai commented on this pull request.



>      if (fnamedPipe)
 	Fclose(fnamedPipe);
 
-    if (pid)
-	waitpid(pid, &status, 0);
+    if (gpgPid)
+	waitpid(gpgPid, &status, 0);
 

Not a problem introduced in this patch so not something you need to address, just noting: the exit section duplicates much of what is being done just above it. The whole point of having exit/error labels to jump to is to avoid just that...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/938#pullrequestreview-323630000
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20191127/1a5ce2cf/attachment.html>