[Rpm-maint] [rpm-software-management/rpm] Cannot leave comments after %endif (#829)

[pavlinamv]

> The constructive solution to the problem would be supporting spec #-comments at arbitrary positions, just like the shell does.

Supporting spec #-comments at arbitrary positions can potentially cause some problems. That is why I looked  into spec files and search for occurrences of #. There are several types of interesting lines:

1/ **#** used in define (in quotes or before backslash, ...)
```
   %define coolkey_module "CoolKey PKCS #11 Module"
   %global auto_register_macro_post() # create it if it doesn't already exist \
```

2/ **#** used in a script that does not denote a comment
```
sed -i -e '/^#!/ c #!%{__perl}' bin/podspell
%{_bindir}/echo -e "\e[101m -=#=- Tests disabled -=#=- \e[0m"
```

3/ **#** used in a changelog:
```   
Ticket #321 - krbExtraData is being null modified and replicated on each ssh login
```


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/829#issuecomment-529856455
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190910/501bbe32/attachment.html>