[Rpm-maint] [rpm-software-management/rpm] Add an error message when rpm fails to open a pipe for shell expansion (#862)

[Panu Matilainen]

Yup, an error message is indeed missing there. The message lacks context though, might want to add the command it's trying to execute to give both the user and the developer who gets bugged a little bit of context as to what rpm was trying to do (although the command itself has little to do with the failure in this case)

Also when system calls (and similar) fail, it's usually a good idea to add strerror(errno) to the output to give the user a clue as to why it failed. popen() errno behavior seems a bit strange though, the manual says "The popen() function does not set errno if memory allocation fails." but that's exactly what I get if I make the shell unexecutable. ENOMEM seems a bit unexpected in that situation :D

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/862#issuecomment-534957128
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20190925/640352b5/attachment.html>