[Rpm-maint] [rpm-software-management/rpm] Export CC and CXX in __build_pre (#1154)

[Panu Matilainen]

This seems like a fairly obvious thing on the outset, but doing this would break anybody setting CC/CXX externally in the environment. Which is a long-standing "feature" that somebody somewhere is almost surely using.

If we add CC/CXX then why not CPP too? And the whole other bunch of related env variables?

Another issue here is that the existing macros basically reflects what rpm itself was built with, which has little relevance to how something else should be built with. Which kinda makes me think that rpm shouldn't have these macros in the first place, and usage should be conditionalized so the values are only used if defined. But I dunno.

Finally, assuming we added such a thing, it'd probably better belong in %set_build_flags than %__build_pre.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1154#issuecomment-607195264
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20200401/9692b448/attachment.html>