[Rpm-maint] [rpm-software-management/rpm] Enable thread autodetection for a parallel compression. (#1324)

[Panu Matilainen]

@pmatilai commented on this pull request.



> @@ -1143,9 +1132,11 @@ static rpmzstd rpmzstdNew(int fdno, const char *fmode)
 	    goto err;
 	}
 
-	if (threads > 0)
+	threads = get_compression_threads (threads);
+	if (threads > 0) {
 	    if (ZSTD_isError (ZSTD_CCtx_setParameter(_stream, ZSTD_c_nbWorkers, threads)))
 		rpmlog(RPMLOG_WARNING, "zstd library does not support multi-threading\n");

Not introduced in this commit of course, but while in the neighborhood... This should really either be RPMLOG_DEBUG or marked for translation, and I think RPMLOG_DEBUG is the way to go, just to avoid endless, useless warning spew.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1324#pullrequestreview-470167841
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20200818/0d0d7af7/attachment-0001.html>