[Rpm-maint] [rpm-software-management/rpm] Allow database probing if _db_backend is not set (#1451)

Michael Schroeder notifications at github.com
Thu Dec 3 12:38:37 UTC 2020


@mlschroe commented on this pull request.



> @@ -97,7 +98,7 @@ dbDetectBackend(rpmdb rdb)
 		rpmlog(RPMLOG_WARNING,
 			_("Converting database from %s to %s backend\n"),
 			ondisk->name, cfg->name);
-	    } else {
+	    } else if (*db_backend) {

With your code there will no longer be a warning for unknown but configured backends in read-only mode. We can also catch this in the invalid _db_backend test above if you want this to error out instead. But if we allow it I think we should print a warning.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1451#discussion_r535193474
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20201203/222f6a38/attachment.html>


More information about the Rpm-maint mailing list