[Rpm-maint] [rpm-software-management/rpm] Allow database probing if _db_backend is not set (#1451)

Michael Schroeder notifications at github.com
Thu Dec 3 13:07:54 UTC 2020


@mlschroe commented on this pull request.



> @@ -97,7 +98,7 @@ dbDetectBackend(rpmdb rdb)
 		rpmlog(RPMLOG_WARNING,
 			_("Converting database from %s to %s backend\n"),
 			ondisk->name, cfg->name);
-	    } else {
+	    } else if (*db_backend) {

We can use
```
if (ondisk && ondisk != cfg) {
    if (*db_backend) {
        if (rdb->db_flags & RPMDB_FLAG_REBUILD) {
        ...
```
and change the `cfg->name` to `db_backend` just for consistency. Would that be more to your taste?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1451#discussion_r535211831
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20201203/ee07f905/attachment.html>


More information about the Rpm-maint mailing list