[Rpm-maint] [rpm-software-management/rpm] Allow database probing if _db_backend is not set (#1451)

[Panu Matilainen]

@pmatilai commented on this pull request.



> @@ -97,7 +98,7 @@ dbDetectBackend(rpmdb rdb)
 		rpmlog(RPMLOG_WARNING,
 			_("Converting database from %s to %s backend\n"),
 			ondisk->name, cfg->name);
-	    } else {
+	    } else if (*db_backend) {

Conditionalizing and using db_backend instead sounds fine to me. Might also want to update the comments to explain what exactly is the intention here, because like said, it's surprisingly subtle.
That debug log note in the case it goes on auto-probe in the non-warning case wouldn't hurt either.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1451#discussion_r535222846
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20201203/ac8d1779/attachment.html>