[Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)

[Neal Gompa (ニール・ゴンパ)]

Conan-Kudo commented on this pull request.



> +	break;
+    case EM_MIPS:
+	elf_machine = "mips";
+	break;
+    case EM_PPC:
+    case EM_PPC64:
+	elf_machine = "ppc";
+	break;
+    case EM_S390:
+	elf_machine = "s390";
+	break;
+    case EM_ARM:
+	if ((ehdr->e_flags | EF_ARM_ABI_FLOAT_HARD) == EF_ARM_ABI_FLOAT_HARD)
+		elf_machine = "armhfp";
+	if ((ehdr->e_flags | EF_ARM_ABI_FLOAT_SOFT) == EF_ARM_ABI_FLOAT_SOFT)
+		elf_machine = "armsfp";

Erk, nope, that's no bueno:

```
tools/elfdeps.c:130:47: error: bitwise comparison always evaluates to false [-Werror=tautological-compare]
  130 |  if ((ehdr->e_flags & ~EF_ARM_ABI_FLOAT_HARD) == EF_ARM_ABI_FLOAT_HARD)
      |                                               ^~
tools/elfdeps.c:132:47: error: bitwise comparison always evaluates to false [-Werror=tautological-compare]
  132 |  if ((ehdr->e_flags & ~EF_ARM_ABI_FLOAT_SOFT) == EF_ARM_ABI_FLOAT_SOFT)
      |                                               ^~
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1038#discussion_r374110704
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20200203/a45dde98/attachment.html>