[Rpm-maint] [rpm-software-management/rpm] Add dbus-announce plugin (#1255)

[Panu Matilainen]

@pmatilai commented on this pull request.



> +
+    msg = dbus_message_new_signal("/org/rpm/Transaction", // object name
+				  "org.rpm.Transaction", // interface name
+				  name); // name of the signal
+    if (NULL == msg) {
+	return RPMRC_FAIL;
+    }
+
+    dbcookie = rpmdbCookie(rpmtsGetRdb(ts));
+    if (!dbus_message_append_args(msg, DBUS_TYPE_STRING, &dbcookie)) {
+	return RPMRC_FAIL;
+    }
+    dbcookie = _free(dbcookie);
+
+    if (!dbus_connection_send(state->bus, msg, &serial)) {
+	return RPMRC_FAIL;

Hmm, failing the entire transaction if dbus announce fails seems a bit dramatic. Then again, if people are actually relying on these signals... 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1255#pullrequestreview-427912576
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20200610/219d231c/attachment.html>