[Rpm-maint] [rpm-software-management/rpm] Always fail build on dependency generator failures (#1183) (#1271)

[Panu Matilainen]

On 6/23/20 5:16 PM, rpm-maint wrote:
> Architecture is hardcoded in test and thus it fails on anything not x86_64
> :-(
> 
> See
> http://pkgsubmit.mageia.org/uploads/failure/cauldron/core/release/20200623135516.tv.duvel.30441/log/rpm-4.16.0-0.beta2.1.mga8/build.0.20200623135605.log
> 
> --- - 2020-06-23 13:59:13.826080861 +0000
> +++ 
> /home/iurt/rpmbuild/BUILD/rpm-4.16.0-beta2/tests/rpmtests.dir/at-groups/329/stderr 
> 2020-06-23
> 13:59:13.811945165 +0000
> @@ -1,3 +1,3 @@
> -error: Requirename generator /tmp/fail.req failed:
> /build/BUILDROOT/shebang-0.1-1.x86_64/bin/shebang
> - Requirename generator /tmp/fail.req failed:
> /build/BUILDROOT/shebang-0.1-1.x86_64/bin/shebang
> +error: Requirename generator /tmp/fail.req failed:
> /build/BUILDROOT/shebang-0.1-1.i386/bin/shebang
> + Requirename generator /tmp/fail.req failed:
> /build/BUILDROOT/shebang-0.1-1.i386/bin/shebang

Doh, what a stupid issue, thanks for reporting. Fixed in
https://github.com/rpm-software-management/rpm/pull/1283, but *please* 
open tickets for such findings. Emails and comments to old PRs/commits 
lack proper tracking, and get all too easily lost in the noise to begin 
with.

	- Panu -



-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1271#issuecomment-648624812
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20200623/0070c12c/attachment.html>