[Rpm-maint] [rpm-software-management/rpm] GPG_TTY warning causes test-suite failure in mock (#1290)

[Panu Matilainen]

Here's an simple reproducer that doesn't need messing with mock:

> [pmatilai🎩︎lumikko rpm]$ cp tests/data/RPMS/hello-2.0-1.x86_64.rpm /tmp/
[pmatilai🎩︎lumikko rpm]$ ./rpmsign --addsign /tmp/hello-2.0-1.x86_64.rpm < /dev/null
/tmp/hello-2.0-1.x86_64.rpm:
warning: Could not set GPG_TTY to stdin: Inappropriate ioctl for device
[pmatilai🎩︎lumikko rpm]$

Or to reproduce in the test-suite context, `make check < /dev/null`.

So actually the warning is quite appropriate in this situation, that this works at all in the test-suite depends on the key not having a passphrase at all so nothing will need to ask for it. The right thing to do is probably to set GPG_TTY explicitly from the test-suite instead - I'll submit a PR in a minute.

(so typical, I assign this to you but then end up looking at it myself, trying to kill time before vacation...)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1290#issuecomment-649448251
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20200625/d158c529/attachment.html>