[Rpm-maint] [rpm-software-management/rpm] rpmbuild logging tweaks (#1429)
Panu Matilainen
notifications at github.com
Mon Nov 23 11:25:51 UTC 2020
I was about to ask whether you're expecting a review on this (generally PR's with failing tests will not be looked at), but then I noticed this is a "draft", I didn't even know GH has such a (handy looking) feature so thanks for the tip :smile:
Since it's a work-in-progress by label, didn't look too closely, but couple remarks:
- Do split the log message improvements to a separate PR from the rpmlog infrastructure work
- For the task of finding the last newline, the standard C library has (for once!) strrchr() so you don't need to do that manually
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1429#issuecomment-732100702
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20201123/b630540a/attachment.html>
More information about the Rpm-maint
mailing list