[Rpm-maint] [rpm-software-management/rpm] Fix Fseek for offset > 2GiB (#1381)

[Panu Matilainen]

@pmatilai commented on this pull request.



> @@ -382,7 +382,7 @@ static ssize_t fdWrite(FDSTACK_t fps, const void * buf, size_t count)
 
 static int fdSeek(FDSTACK_t fps, off_t pos, int whence)
 {
-    return lseek(fps->fdno, pos, whence);
+    return (lseek(fps->fdno, pos, whence) == -1 ? -1 : 0);

Mm, sorry for missing this earlier, was just about to merge when I spotted something strange with the parenthesis: enclosing it all in parenthesis makes no sense and doesn't help readability either, it should be:

```
return (lseek(fps->fdno, pos, whence) == -1) ? -1 : 0;
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1381#pullrequestreview-503530765
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20201006/33eac583/attachment.html>