[Rpm-maint] [rpm-software-management/rpm] elfdeps: Generate dependencies on non-executable shared libraries (#1393)

[Panu Matilainen]

I agree with @mikhailnov this seems to be a somewhat strange way to go about this. Maybe it's been the path of least disruption for adding a distro-specific patch, but I think for upstreaming purposes the logic of this all needs reconsidering.

This breaks a fairly fundamental and long-standing principle of requires only being added to executables, so if you want to disable dependency tracking for a file you just chmod a-x it. For a long, long time this was the only means of affecting dependency generation on per-file basis. OTOH in those simpler days we also didn't have ELF executables masquerading as ET_DYN. Honoring the x-bit for one but not the other would only seem to make things inconsistent to me, especially as an increasing number of *executables* are ET_DYN these days, so they'll end up getting their requires extracted whether x mode bit is set or not.

This also breaks anything overriding __elf_* dependency generation in a spec, but maybe that's not as common as I wouldn't thought (doesn't seem to be any cases in Fedora, shockingly). 

Those breakages will need to be considered and at the very least noted when changing such behavior.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1393#issuecomment-706887705
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20201011/99bd56db/attachment.html>