[Rpm-maint] [rpm-software-management/rpm] Fix logic error in grabArgs() (#1411)

Panu Matilainen notifications at github.com
Fri Oct 23 12:27:33 UTC 2020


@pmatilai commented on this pull request.



> @@ -948,7 +948,7 @@ grabArgs(MacroBuf mb, const rpmMacroEntry me, const char * se,
 	splitQuoted(&argv, s, " \t");
 	free(s);
 
-	cont = ((*lastc == '\0' || *lastc == '\n') && *(lastc-1) != '\\') ?
+	cont = *lastc == '\0' || (*lastc == '\n' && *(lastc-1) != '\\') ?

Care to add parenthesis around `*lastc == '\0'` to make it a bit more obvious?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1411#pullrequestreview-515618314
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20201023/b9216035/attachment.html>


More information about the Rpm-maint mailing list