[Rpm-maint] [rpm-software-management/rpm] rpmbuild sets RPMFILE_DOC on files in %{_datadir}/doc regardless of spec file notation (#1368)

[David Cantrell]

On lines 1228 and 1229 in build/files.c, I found this:

````
if (!isSrc && isDoc(fl->docDirs, flp->cpioPath))
    flp->flags |= RPMFILE_DOC;
````

git blame shows this has been around for at least 8 years, so this is hardly anything new.  I noticed that any files in install to %_defaultdocdir as defined in the macros end up getting marked in the rpm header with RPMFILE_DOC.  This is regardless of how I mark the files in the spec file.

If I use any path other than %_defaultdocdir and install files marked as %doc, the spec file rules take effect.  But it seems any time you list a file in %files that begins with %_defaultdocdir, it will also be marked as an RPMFILE_DOC in the package.

This feels like incorrect behavior to me because the %doc macro is ignored only for these cases.  Shouldn't the %doc macro in the spec file control the RPMFILE_DOC bit in the header?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1368
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20200921/3fcad91f/attachment.html>