[Rpm-maint] [rpm-software-management/rpm] pythondistdeps: Switch to importlib.metadata (#1317)
torsava
notifications at github.com
Wed Sep 23 09:12:23 UTC 2020
@torsava commented on this pull request.
> + if isdir(path):
+ path = dirname(path)
+ res = re.search(r"/python(?P<pyver>\d+\.\d+)/", path)
This breaks detection of Python version from the name of the egg-info file. And I think you misunderstood me, I wasn't doubting the usefulness of the variable, I was asking why do you do `dirname` at all.
```suggestion
res = re.search(r"/python(?P<pyver>\d+\.\d+)/", path)
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1317#pullrequestreview-494457340
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20200923/ed9c9fff/attachment.html>
More information about the Rpm-maint
mailing list