[Rpm-maint] [rpm-software-management/rpm] pythondistdeps: Switch to importlib.metadata (#1317)

torsava notifications at github.com
Wed Sep 23 09:21:33 UTC 2020


@torsava commented on this pull request.



>                      else:
-                        dep_normalized_name = dep.key
+                        dep_normalized_name = dep.key.replace('_', '-')

Why do you still do the `replace` here, but not in the other places where you use `dep.key`? I'm not saying it's necessarily wrong, but I don't understand it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1317#pullrequestreview-494464867
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20200923/3ac0f32a/attachment.html>


More information about the Rpm-maint mailing list