[Rpm-maint] [rpm-software-management/rpm] pythondistdeps: Switch to importlib.metadata (#1317)

torsava notifications at github.com
Thu Sep 24 09:20:56 UTC 2020


@torsava commented on this pull request.



>                      else:
-                        dep_normalized_name = dep.key
+                        dep_normalized_name = dep.key.replace('_', '-')

The newest version looks good to me, and tests are passing.

The [documentation for pkg_resources](https://setuptools.readthedocs.io/en/latest/pkg_resources.html) says about `key`: An all-lowercase version of the project_name, useful for comparison or indexing.
>From there you have to look up `project_name` and then `safe_name` function which generates it. So if we go by documentation, dots are not allowed in `key`. However, if you actually test it, they are there.

What do you think, @hroncok ?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1317#discussion_r494166167
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20200924/12ce34cf/attachment.html>


More information about the Rpm-maint mailing list