[Rpm-maint] [rpm-software-management/rpm] Ignore comment line contents in macro files (#1659) (#1661)
Panu Matilainen
notifications at github.com
Wed Apr 28 07:29:49 UTC 2021
Previously %{ and similar in macro file comment line would cause the
line continuation logic to trigger and silently eat macro definitions
up to the next empty line. Since 75275a87cff04da65d3557f2c40ea2b526528c4c
we permit empty lines inside macro definitions, which would cause the
whole remaining file to be silently skipped (RhBug:1953910)
Only ever parse macro file lines starting with %, and add a test for
the case.
Actual patch by Michael Schroeder, testcase by undersigned.
Fixes: #1659
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/1661
-- Commit Summary --
* Ignore comment line contents in macro files (#1659)
-- File Changes --
M rpmio/macro.c (8)
M tests/data/macros.testfile (7)
M tests/rpmmacro.at (17)
-- Patch Links --
https://github.com/rpm-software-management/rpm/pull/1661.patch
https://github.com/rpm-software-management/rpm/pull/1661.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1661
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20210428/47a8a2e0/attachment-0001.html>
More information about the Rpm-maint
mailing list