[Rpm-maint] [rpm-software-management/rpm] Fixed issues find by coverity (#1535)

[Panu Matilainen]

I'm afraid you missed the point about my commit message: the code is totally obvious and don't need in-detail explanations. It's the summary that is the problem. When somebody is browsing the history, the one-line summary should be descriptive enough to immediately answer the question: "is this commit potentially relevant for me?" without having to look at the rest of the message, much less code. This fails that criteria - it doesn't say which subsystem or component is in question, and it doesn't even describe the kind of issue being fixed. That it was found by Coverity is totally irrelevant to the relevance question, and many of the "issues" found by static analysis are theoretical or even false positives, these are concrete leaks and as such, important. It however happens in a faraway corner of a special purpose plugin, so for most people it's actually not *that* relevant.

I already suggested a precise and concise message which would not need any further explanations: 
"Fix resource leaks in fapolicyd plugin".



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1535#issuecomment-779074379
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20210215/bf3ab2d5/attachment.html>