[Rpm-maint] [rpm-software-management/rpm] Hardlink handling cleanups + fixes (#1540)

[Panu Matilainen]

Details in commit messages, but brief summary:
- add some missing diagnostics to file unpacking and hardlink handling
- always use the same code path to unpack files
- streamline the hardlink logic, consolidate to one place
- fix a case where partially skipped hardlink set will miss their metadata getting set

This deserves some specific test-cases as well. Will add, but don't let that prevent reviewing otherwise. The hardlink logic with the skipped files scenarios and all is a tricky piece of code.
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/1540

-- Commit Summary --

  * Add hardlink helper to fsm to make it debuggable
  * Make file open and close in fsm debuggable
  * Streamline + consolidate the hardlink handling logic
  * Add diagnostics to archive unpacking

-- File Changes --

    M lib/fsm.c (132)
    M lib/rpmarchive.h (1)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/1540.patch
https://github.com/rpm-software-management/rpm/pull/1540.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1540
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20210216/48b67a66/attachment.html>