[Rpm-maint] [rpm-software-management/rpm] Avoid incrementing a pointer past the end (#1489)

Panu Matilainen notifications at github.com
Wed Feb 17 08:20:04 UTC 2021


Actually in the latest form, the code is obvious enough that it doesn't need a comment at all. Just move the whole explanation to the commit message and we're good here.

That's a generic preference BTW:  comments should be used sparingly, and in particular multiline comments are like neon signs which should be reserved for very special danger zones. If the neon signs are everywhere, they do nothing but blind you from the code itself. In the git era, commit messages are a far better place to document the details.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1489#issuecomment-780386908
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20210217/8660b278/attachment.html>


More information about the Rpm-maint mailing list