[Rpm-maint] [rpm-software-management/rpm] ‘hdrblobInit’: check pointer is 8-byte aligned (#1499)

[Demi Marie Obenour]

> On a second thought, NAK. There are too many redundant checks in the code as it is, and adding these kind of just-in-case checks doesn't do anything to help spot the actually crucial missing ones. Forest from the trees, you know.
> 
> If somebody passes a random non-malloced address to headerImport() or friends, that's a bug in the caller code.
> 
> Apologies for asking you to do extra work and then reject anyway, but there's simply too much on the plate as it is.

That’s understandable.  I will file a separate PR with a documentation fix, so that callers know what to do.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1499#issuecomment-780702430
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20210217/f50ab84d/attachment.html>