[Rpm-maint] [rpm-software-management/rpm] Fix regression from commit 165330b7bf0757e30fa8a6de9998a564fb62796f (#1545)
Demi Marie Obenour
notifications at github.com
Fri Feb 19 08:56:17 UTC 2021
> Note the commit message:
>
> > The exit code condition is getting more complicated now so move it to helper variable, assume failure for a safe default.
>
> Shortness is only a goal if it helps readability.
Indeed that is true. Another option would have been to re-introduce the earlier check, but this is more readable, IMO.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1545#issuecomment-781932960
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20210219/a80ba231/attachment.html>
More information about the Rpm-maint
mailing list