[Rpm-maint] [rpm-software-management/rpm] Security fixes for the OpenPGP parser (#1677)
Demi Marie Obenour
notifications at github.com
Wed Jun 16 14:00:56 UTC 2021
> It's a bit late by now, but of course it would've helped. I've said many many times that these kind of mega PR's have close to zero chance of being accepted because they're not meaningfully reviewable on GH.
>
> PR's can be more than one commit but the commits need to be _closely_ related in the sense that all of them must go in at once or not at all. Sprinkling anything unrelated into it will quite effectively stop a review from progressing. Far worse is multiple mega PR's overlapping and containing different versions of commits etc.
Thanks! Would you mind if I made a PR adding this to CONTRIBUTING.md? That might have avoided quite a bit of confusion.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1677#issuecomment-862406316
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20210616/0be7a69c/attachment.html>
More information about the Rpm-maint
mailing list