[Rpm-maint] [rpm-software-management/rpm] Make the rpmdb keyring type macro-configurable (#1575)

[Neal Gompa (ニール・ゴンパ)]

@Conan-Kudo commented on this pull request.



> @@ -378,13 +378,18 @@ static void loadKeyring(rpmts ts)
     /* Never load the keyring if signature checking is disabled */
     if ((rpmtsVSFlags(ts) & RPMVSF_MASK_NOSIGNATURES) !=
 	RPMVSF_MASK_NOSIGNATURES) {
+	char *kt = rpmExpand("%{?_keyring}", NULL);

I'm not a fan of cryptic variables like `kt`, but we do this so much already... I debated whether I should ask to not make this worse, but ehh... In any case, here's a _soft_ ask to consider making this a clearer variable, but not a hard requirement.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1575#pullrequestreview-609564718
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20210311/e7126e32/attachment.html>