[Rpm-maint] [rpm-software-management/rpm] Better detection of I/O errors (#1566)
Michal Domonkos
notifications at github.com
Mon Mar 15 17:27:06 UTC 2021
Oh, indeed. Thanks for spotting this!
Also kudos for checking for the `fprintf()` return value - although it still returns a positive value in case of an `ENOSPC`, there could be other errors, so why not check for them right away.
That said, I realized I should've moved the `free(val)` statement above the new conditional in my original patch. So while at it, could you please incorporate that, too? Either storing the return value of `fprintf()` in a variable and then doing the `free(val)`, or just putting another `free(val)` call just before the `exit(EXIT_FAILURE)` statement should be fine.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1566#issuecomment-799603408
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20210315/8e3c6dc9/attachment.html>
More information about the Rpm-maint
mailing list