[Rpm-maint] [rpm-software-management/rpm] Undefined pointer comparison in macro.c (#1602)

[Panu Matilainen]

This is actually a *wonderful* example: just like compiler warnings, undefined behavior is best viewed as a canary that points to buggy code, rather than flaw in itself. Much, much damage to codebases around the world is done by "fixing" compiler warnings, and undefined behavior is not any different.

@mlschroe 's version fixes an ages old, very concrete bug (even an RFE) in the macro parser. It wasn't misbehaving because of the allegedly undefined behavior but because it was just a piece of bad old code, led to by the undefined behavior alert.

Fixed by #1606

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1602#issuecomment-808163514
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20210326/e6e3a8f8/attachment.html>