[Rpm-maint] [rpm-software-management/rpm] Drop extra newlines from spec parser messages (#1591)

Panu Matilainen notifications at github.com
Mon Mar 29 13:25:57 UTC 2021


The extra newlines are indeed there, try eg "%trigger" line to trigger various errors, but probably varies from one error to another due to all sorts of internal wacko.

The path of less changes may be instead eliminating the newlines as we parse, but there could be dragons in that direction too. If we need to change every other log message in the build code, we should probably take the opportunity to improve the error logging in general, like you noted by putting it into a specialized function for uniform formatting etc. And *if* we go there, outputting the problematic line on a different line from the error message would probably make sense (compare to eg gcc/clang error reporting)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1591#issuecomment-809375066
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20210329/3b85e71d/attachment.html>


More information about the Rpm-maint mailing list