[Rpm-maint] [rpm-software-management/rpm] Add dbus-announce plugin (#1255)

Florian Festi notifications at github.com
Wed May 26 13:31:08 UTC 2021


@ffesti commented on this pull request.



> +    dbcookie = rpmdbCookie(rpmtsGetRdb(ts));
+    if (!dbus_message_append_args(msg, DBUS_TYPE_STRING, &dbcookie)) {
+	goto err;
+    }
+    dbcookie = _free(dbcookie);
+
+    if (!dbus_connection_send(state->bus, msg, &serial)) {
+	goto err;
+    }
+    dbus_connection_flush(state->bus);
+    return RPMRC_OK;
+
+ err:
+    rpmlog(RPMLOG_WARNING,
+	   "dbus_announce plugin: Error sending message (%s)\n",
+	   name);

At closer look there is no good reason to deal with the serial number here. Dropped it completely.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1255#discussion_r639727856
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20210526/163d136e/attachment.html>


More information about the Rpm-maint mailing list