[Rpm-maint] [rpm-software-management/rpm] Justus/openpgp fixes (PR #1813)

[Justus Winter]

@teythoon commented on this pull request.



> @@ -503,6 +500,9 @@ static int pgpPrtSubType(const uint8_t *h, size_t hlen, pgpSigType sigtype,
 	case PGPSUBTYPE_REVOKE_REASON:
 	case PGPSUBTYPE_FEATURES:
 	case PGPSUBTYPE_EMBEDDED_SIG:
+	    pgpPrtHex("", p+1, plen-1);
+	    break;
+	case PGPSUBTYPE_NOTATION:

> So Sequoia flags one/some of these packets as critical by default?

Yes.

> Which ones?

- signature creation time
- signature expiration time
- exportable certification
- trust signature
- regular expression
- revocable
- key expiration time
- revocation key
- primary userid
- key flags
- signature target
- embedded signature

Glancing at that list, I'd say relevant for RPM's use case are:

- signature creation time
- signature expiration time
- key expiration time
- revocation key
- key flags
- embedded signature

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1813#discussion_r741961734
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20211103/bc1a4042/attachment.html>