[Rpm-maint] [rpm-software-management/rpm] Justus/openpgp fixes (PR #1813)

[Panu Matilainen]

@pmatilai commented on this pull request.



> @@ -503,6 +500,9 @@ static int pgpPrtSubType(const uint8_t *h, size_t hlen, pgpSigType sigtype,
 	case PGPSUBTYPE_REVOKE_REASON:
 	case PGPSUBTYPE_FEATURES:
 	case PGPSUBTYPE_EMBEDDED_SIG:
+	    pgpPrtHex("", p+1, plen-1);
+	    break;
+	case PGPSUBTYPE_NOTATION:

After sleeping over it a bit, what probably bugs me here is this:
If Sequoia marks all those tags as critical then AFAICS rpm is right per the spec to fail on them, yet this is "fixing" something on rather arbitrary grounds. As per the above comments, the actual agenda here is to tweak rpm's interpretation to support Sequoia created keys. State *that* as the reason for the change, and it's totally okay by me.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1813#discussion_r746427218
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20211110/9ff96fe3/attachment.html>