[Rpm-maint] [rpm-software-management/rpm] Revert "Don't brp-strip .ko files" (PR #1824)

[Michal Domonkos]

The original commit might have seemed like an easy remedy for
third-party modules affected by commit 0ab151a (such as rhbz#1967291),
but it also prevents the modules built from the kernel tree (which
employ a different signing strategy, see below) from being stripped off
of debug and symbol data, so it's not the correct solution after all.

Simply put, *.ko files *are* ELF files, so there's no good reason to
skip them.

Third-party modules should instead adopt the same hack as the in-tree
ones, i.e. overriding the %__spec_post_install macro so that the signing
occurs as a last step, after any kind of stripping has taken place.
Example from kernel.spec:

%define __modsign_install_post \
  # Do the signing here
[...]
%define __spec_install_post \
  # eu-strip(1) gets called here
  %{?__debug_package:%{__debug_install_post}}\
  %{__arch_install_post}\
  # ... or strip(1) gets called here
  %{__os_install_post}\
  %{__remove_unwanted_dbginfo_install_post}\
  %{__modsign_install_post}

It's still a hack, but it's better than avoiding the strip altogether.

This reverts commit cfdb8300f6e3aed0abc41406a3c4737eb1192067.
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/1824

-- Commit Summary --

  * <a href="https://github.com/rpm-software-management/rpm/pull/1824/commits/f5996d33953b267e7c54603e686c7b5b49ab6927">Revert "Don't brp-strip .ko files"</a>

-- File Changes --

    M scripts/brp-strip (2)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/1824.patch
https://github.com/rpm-software-management/rpm/pull/1824.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1824
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20211110/956a38f1/attachment-0001.html>