[Rpm-maint] [rpm-software-management/rpm] cleanup rpmpgp.h includes (PR #1829)

Justus Winter notifications at github.com
Tue Nov 16 15:50:39 UTC 2021


> No objection in principle,

Cool.

> however pgpHexStr() is unfortunately part of the public API and we don't want a soname bump just because of this one silly thing.

Yeah, I was worried about that.  I now see that even rpmpgp.h is part of the public interface.  Now I'm even more worried.  I don't see a way to meaningful refactor the PGP implementation's interface without flat-out dropping some of the functionality.

> So either drop the s/pgp/rpm/ rename for now, or add (back) a wrapper function by the name pgpHexStr() which can be additionally deprecated, to be removed from the API+ABI when a suitable opportunity rises.

I think I'll just drop all but the first commit for now.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1829#issuecomment-970407311
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20211116/378607f7/attachment.html>


More information about the Rpm-maint mailing list