[Rpm-maint] [rpm-software-management/rpm] cleanup rpmpgp.h includes (PR #1829)

[Panu Matilainen]

The include in rpmfiles.h is a leftover from times when some functions took `pgpHashAlgo` as an argument and not strictly needed anymore. If something FTBFS because of that it's at least trivial to fix - don't worry about that. ABI is the bigger concern because soname bumps in rpm are kinda painful.

As for the overall picture: yes, we'll need to break some eggs to make the omelette. That's okay too, much of the stuff in rpmpgp.h doesn't belong there in the first place, and much of the rest shouldn't be public either. So breakage is okay and totally expected for the bigger refactoring when we get to that, but a lone rename of a function is a gratuitous breakage from ABI POV. 

Hopefully that clarifies it a bit.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1829#issuecomment-971384789
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20211117/efef3ad3/attachment.html>