[Rpm-maint] [rpm-software-management/rpm] Fix a couple of minor issues detected by the cppcheck tool. (PR #1846)

[Peter Pentchev]

Hi,

Thanks a lot for developing and maintaining RPM!

What do you think about these two trivial changes caught by the cppcheck tool? It reported a lot of other false positives, as well as something strange in the lib/backend/ndb/rpmxdb.c file's moveblobstofront() function that I cannot really determine whether it is a genuine bug or a deliberate attempt to get the program to segfault in out-of-resources situations, but these two minor issues seem genuine to me.

Thanks in advance for your time, and keep up the great work!

G'luck,
Peter

You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/1846

-- Commit Summary --

  * Fix __cplusplus misspelled as _cplusplus.
  * Avoid 32-bit integer overflow with 1 << 31.

-- File Changes --

    M build/rpmbuild.h (2)
    M build/rpmfc.h (2)
    M lib/rpmfiles.h (2)
    M lib/rpmplugin.h (2)
    M lib/rpmts.h (2)
    M rpmio/expression.c (2)
    M sign/rpmsignfiles.h (2)
    M sign/rpmsignverity.h (2)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/1846.patch
https://github.com/rpm-software-management/rpm/pull/1846.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1846
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20211126/ab021172/attachment.html>