[Rpm-maint] [rpm-software-management/rpm] Add %collect macro for easy file manifest creation (PR #2035)

[Michal Domonkos]

@dmnks commented on this pull request.



>      rpmRC res = RPMRC_OK;
     int allow_relative = (RPMFILE_PUBKEY|RPMFILE_DOC|RPMFILE_LICENSE);
 
     t = buf;
-    while ((s = strtokWithQuotes(t, " \t\n")) != NULL) {

That's a good point and I don't think you're missing anything. In fact, we might as well just simplify the whole quotation semantics as follows:
- No quotes means interpret globs as usual.
- Quotes mean don't interpret any globs.
That way, if we split on newlines, spaces wouldn't have to be dealt with in any special way. We also wouldn't need to support backslash escaping *at all* since quotes would do that. This would simplify #1903 quite significantly.

The current approach I chose for #1903 is to support backslashes properly, also support them for spaces, and to keep the possibility to allow multiple files per line by removing the "artificial" conditional we have for it, however taking a step back now, it does seem to be a little bit on the overkill side of the spectrum :smile: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2035#discussion_r858439353
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2035/review/952983801 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20220426/82c8b68d/attachment.html>