[Rpm-maint] [rpm-software-management/rpm] Shell-like escaping support in %files (PR #1903)

[Panu Matilainen]

@pmatilai commented on this pull request.



>      rpmRC res = RPMRC_OK;
     int allow_relative = (RPMFILE_PUBKEY|RPMFILE_DOC|RPMFILE_LICENSE);
 
     t = buf;
-    while ((s = strtokWithQuotes(t, " \t\n")) != NULL) {

Not introduced or changed in this patch, but on a related note: it's more than a little hysterical that we split the line with tabs and spaces, forcing all this quoting on them, BUT then we don't allow more than one file per line anyway. Except for special %doc and %license.

So unless I'm missing something here, we could split by newline alone when allow_relative is false, and have spaces and tabs in filenames "just work" with zero quoting.

(ininitially commented this on a wrong PR)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1903#pullrequestreview-953013978
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/1903/review/953013978 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20220426/115a859d/attachment-0001.html>