[Rpm-maint] [rpm-software-management/rpm] configure.ac: add linux-gnux32 variant to triplet handling (PR #2143)
Panu Matilainen
notifications at github.com
Mon Aug 15 08:16:44 UTC 2022
It's not so much the change itself, it's the lack of rationale needed to understand why this is needed all of a sudden and why it looks like an incomplete "support x32" patch. So okay you have a custom `rpmrc`, that explains how it works at all. That's what I was trying to dig out above.
And now we've learned that this is to address a build regression in 4.17.1, which makes it something entirely different. I didn't realize we had any changes to this area in that release, but looking closer this check is explicitly added in 1cdb72ae48b7ba689c5c79118f4f0c1b4ffe6b7c and then cherry-picked into 4.17.1. And with that information, the picture starts to form. Just explain the matter properly in the commit message and I've no problem merging it.
Tagging @dmnks as we'll probably need a .1 regression release for 4.17.1 anyway and this matter needs to be considered there too.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2143#issuecomment-1214740966
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/2143/c1214740966 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20220815/654649ad/attachment.html>
More information about the Rpm-maint
mailing list