[Rpm-maint] [rpm-software-management/rpm] Fix expected test output when using Sequoia. (PR #2063)

[Panu Matilainen]

@pmatilai commented on this pull request.



> @@ -621,7 +621,11 @@ rpmRC rpmtsImportPubkey(const rpmts ts, const unsigned char * pkt, size_t pktlen
         if (krc != RPMRC_OK) {
             rpmlog(RPMLOG_ERR, "%s\n", lints);
         } else {
-            rpmlog(RPMLOG_WARNING, "%s\n", lints);
+            if ((rpmtsVSFlags(ts) & RPMVSF_NOLINT)) {
+                // Don't show lints when --nolint is provided.

I think `--nolint` should skip calling pgpPubKeyLint() entirely, that's how such disablers generally behave in rpm. That way it's possible to work around bugs and other gotchas - I only remember regretting *not adding* disablers to some things later, never the other way around.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2063#pullrequestreview-1077185133
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2063/review/1077185133 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20220818/55ce54c0/attachment-0001.html>