[Rpm-maint] [rpm-software-management/rpm] Fix expected test output when using Sequoia. (PR #2063)

[Panu Matilainen]

@pmatilai commented on this pull request.



> @@ -621,7 +621,11 @@ rpmRC rpmtsImportPubkey(const rpmts ts, const unsigned char * pkt, size_t pktlen
         if (krc != RPMRC_OK) {
             rpmlog(RPMLOG_ERR, "%s\n", lints);
         } else {
-            rpmlog(RPMLOG_WARNING, "%s\n", lints);
+            if ((rpmtsVSFlags(ts) & RPMVSF_NOLINT)) {
+                // Don't show lints when --nolint is provided.

That'd be in line with what similar other disablers in RPMVSF_* and others do, eg `--noverify`, `--nosignature`, `--nodeps` and all. All very much "apply shotgun to the foot" dangerous by nature if used carelessly and/or without full understanding. But then of course, there are thousands of sanity/structural checks that don't have such disablers. 

I'm looking at this mainly from the "allow working around bugs in (feature X)" but here it's being added for a very different reason actually, and neither seem *quite* right. Maybe I'll need to meditate on this some more :thinking: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2063#discussion_r949053341
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/2063/review/1077235019 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20220818/5dc3d5d3/attachment-0001.html>